-
Notifications
You must be signed in to change notification settings - Fork 95
dbx_ingestion_monitoring #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
dbx_ingestion_monitoring #126
Conversation
| } | ||
| } | ||
| ], | ||
| "catalog": "chavdarbotev_std", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this say chavdar?
|
|
||
| sys.path.append("../../lib") | ||
|
|
||
| from dbx_ingestion_monitoring.common_ldp import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be called "dbx_ingestion_monitoring"? It sounds very much like https://github.com/databrickslabs/dbx to me
|
|
||
| # Configure logging | ||
| logging.basicConfig( | ||
| level=logging.INFO, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check the formatting of this file, I think might be a mix of 2-spaces and 4-spaces?
| import sys | ||
| import logging | ||
|
|
||
| sys.path.append("../../lib") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| sys.path.append("../../lib") | ||
|
|
||
| from dbx_ingestion_monitoring.common_ldp import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: import * is generally frowned upon
| @@ -0,0 +1,60 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This folder is a bit odd to me, it is called jobs but has notebooks? Should this live in an src directory of one of the DABs projects?
| @@ -0,0 +1,24 @@ | |||
| # This job builds an inverted index mapping pipeline tags to pipeline IDs. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this directory is included from both DABs projects, right? Maybe it should be wrapped into something like common/?
| @@ -0,0 +1,17 @@ | |||
| Copyright (2025) Databricks, Inc. | |||
|
|
|||
| This Software includes software developed at Databricks (https://www.databricks.com/) and its use is subject to the included LICENSE file. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this refer to /LICENSE? You should probably make a copy
This directory contains common code and DABs to deploy observability ETL and dashboards for Databricks ingestion projects. The goal is to provide an example and a starting point for building ingestion observability across pipelines and datasets.
In particular, the package provides:
cloud_file_states, system tables and other."tier:T0;team:data,tier:T1") instead of maintaining lists of pipeline IDsCurrently Generic SDP pipelines and Lakeflow CDC Connector pipelines are supported.